Internal: Fixes ClientTelemetry to use StoreResponseNameValueCollection #3473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NameValueCollectionWrapperFactory is dead code and getting removed. ClientTelemetry is using NameValueCollectionWrapperFactory for auth header related generation. Its usage moved to StoreResponseNameValueCollection.
kirankumarkolli
requested review from
ealsur,
FabianMeiswinkel,
kirillg and
sboshra
as code owners
|
@sourabh1007 please take a look. |
ealsur
reviewed
Sep 26, 2022
ealsur
approved these changes
Sep 26, 2022
kirankumarkolli
deleted the
users/kirankk/client_telemetry_headers_type_fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NameValueCollectionWrapperFactory is dead code and getting removed.
ClientTelemetry is using NameValueCollectionWrapperFactory for auth header related generation. Its usage moved to StoreResponseNameValueCollection.
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Include samples if adding new API, and include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber